Solving ad multifield #687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ifferent number of DoFs per field.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #687 +/- ##
==========================================
- Coverage 87.93% 87.50% -0.44%
==========================================
Files 133 133
Lines 14966 15018 +52
==========================================
- Hits 13161 13142 -19
- Misses 1805 1876 +71 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
The general idea looks good to me. |
…ifferent number of DoFs per field.
…nto solving_ad_multifield
|
@fverdugo ... this PR is ready for review. AD for Multifield Residuals is back again! 😎 😎 😎 The review should focus IMO on providing solutions to the items listed in the PR description. |
fverdugo
approved these changes
Oct 26, 2021
|
Hi @amartinhuertas and @fverdugo ! Thanks for fixing this issue :). I was wondering if you also planned to add the MultiField |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to issue #584
Hi @fverdugo,
find attached a first approach to solve the issue related to the
gradientof a FE functional evaluated at a multifield FE function with different number of DoFs per field. Once we are happy with the current solution forgradient, I will extend this solution tojacobian. Agreed?