Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix in 1st order FEspaces with 1st order models with periodic BCs. #611

Merged
merged 2 commits into from
Jun 4, 2021

Conversation

fverdugo
Copy link
Member

@fverdugo fverdugo commented Jun 4, 2021

This bug was likely introduced by PR #587.

@codecov-commenter
Copy link

codecov-commenter commented Jun 4, 2021

Codecov Report

Merging #611 (4ea02eb) into master (f005b32) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #611      +/-   ##
==========================================
+ Coverage   87.96%   87.97%   +0.01%     
==========================================
  Files         134      134              
  Lines       14241    14241              
==========================================
+ Hits        12527    12529       +2     
+ Misses       1714     1712       -2     
Impacted Files Coverage Δ
src/FESpaces/FESpaceFactories.jl 98.33% <100.00%> (ø)
src/FESpaces/FESpacesWithConstantFixed.jl 76.25% <0.00%> (+2.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f005b32...4ea02eb. Read the comment docs.

@fverdugo fverdugo merged commit ed3b194 into master Jun 4, 2021
@fverdugo fverdugo deleted the fix_fespace_for_periodic_bcs branch June 4, 2021 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants