Fixed buggy sparsecsr generic function #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @fverdugo ! You can proceed with code review of this PR. Let me know if you believe that the tests I have added for rectangular sparse matrices should be more intensive than they are now. |
Codecov Report
@@ Coverage Diff @@
## master #262 +/- ##
==========================================
+ Coverage 88.92% 88.94% +0.01%
==========================================
Files 147 147
Lines 9606 9604 -2
==========================================
Hits 8542 8542
+ Misses 1064 1062 -2
Continue to review full report at Codecov.
|
fverdugo
approved these changes
May 22, 2020
|
@amartinhuertas Can you please add a small line in NEWS.md? |
Yes. Done in 6dc2b7c! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves issue #254