Passing kwargs to simplexify refinement #1015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1015 +/- ##
=======================================
Coverage 88.16% 88.16%
=======================================
Files 179 179
Lines 22569 22569
=======================================
Hits 19899 19899
Misses 2670 2670 ☔ View full report in Codecov by Sentry. |
|
Hey @pmartorell ! Thank you for this! I did not know simplexify had any kwargs, but it is a good thing to have. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@santiagobadia @JordiManyer
This PR passes the kwargs of refine to the simplexify core functions. In particular, it is tested for
positive=true, which generates simplexified partitions with positive volume cells.