Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug in overall payment report #88

Merged
merged 1 commit into from
Apr 20, 2021
Merged

Fix bug in overall payment report #88

merged 1 commit into from
Apr 20, 2021

Conversation

xiangao1
Copy link
Contributor

Changes:

  1. Total payments = total_energy_payments + total_uplift_payments + total_reserve_payments
  2. In write_overall_stats(): 'Total energy payments': lambda overall: overall.total_energy_payments

@xiangao1
Copy link
Contributor Author

Hi @bknueven, would you mind taking a look at this PR? I thought it is an easy fix. Thanks!

bknueven
bknueven approved these changes Apr 20, 2021
View reviewed changes
Copy link
Collaborator

@bknueven bknueven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! We clearly hadn't been looking at this closely after the re-factor.

@bknueven bknueven merged commit 8d712ef into grid-parity-exchange:main Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bknueven bknueven bknueven approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xiangao1 @bknueven