Changing option for --output-sced-demands to --output-sced-loads. #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing corresponding data extractor methods.
bknueven
approved these changes
Oct 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Key feature is providing a fix to a stack trace that results if the existing option --output-sced-demands is used (introduced recently).
This PR changes the --output-sced-demands keyword to --output-sced-loads. Loads are assigned to a bus, and multiple loads can be assigned to a single bus. Demands are not inherently part of the input data to an Egret SCED, but are rather computed as a by-product of the load data. And with price-responsive load, demand doesn't strictly make sense as a static scalar quantity. Thus, this is a first step in the direction of outputting all input load quantities for SCED debugging purposes. Output now shows (load, bus, quantity) triples.
Future commits should/will consider re-visiting demand output and associated, as a realized (post-solve) quantity.