Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
Changes: xamarin/NRefactory@0607a4a...495405a

  * xamarin/NRefactory@495405a6: Merge pull request #2 from jpobst/sdk-style
  * xamarin/NRefactory@e4d5997e: Update some project files to SDK-style.
  * xamarin/NRefactory@60ac8e99: Merge pull request #1 from xamarin/cecilPackageReference
  * xamarin/NRefactory@c2c07caa: Switch Cecil reference to PackageReference.

We are working on using `dotnet build` to build `Xamarin.Android.sln`
and `Xamarin.Android-Tests.sln`.  `dotnet build` requires that all
projects be SDK-style short-form projects.

The `tests/MSBuildDeviceIntegration` integration tests use NRefactory
as part of the debugger tests, to ensure that the debugger can attach
to an app on-device.  In order for `tests/MSBuildDeviceIntegration`
to be buildable with `dotnet build`, NRefactory must have SDK-style
`.csproj` files.

Unfortunately, the [icsharpcode/NRefactory][0] repo only contains
"long-form" projects, has been archived, and is now read-only.

Switch to the [xamarin/NRefactory][1] repo, which is *not* archived
and is maintained by the VSMac team, and bump to a commit which
includes xamarin/NRefactory@e4d5997e, which migrates many of the
`.csproj` files to SDK-style short-form projects.

This allows us to continue our `dotnet build` explorations.

[0]: https://github.com/icsharpcode/NRefactory
[1]: https://github.com/xamarin/NRefactory
  • Loading branch information
jpobst authored Feb 10, 2021
1 parent 9ac280c commit 864bfd5
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .gitmodules
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
branch = master
[submodule "external/nrefactory"]
path = external/nrefactory
url = https://github.com/icsharpcode/NRefactory.git
url = https://github.com/xamarin/NRefactory.git
branch = master
[submodule "external/opentk"]
path = external/opentk
Expand Down

0 comments on commit 864bfd5

Please sign in to comment.