Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor python-gvm API] Step 2: Detach ReportFormat, Ticket, Roles #470

Merged
merged 20 commits into from
May 21, 2021

Conversation

y0urself
Copy link
Member

@y0urself y0urself commented May 20, 2021

What:

  • Changed filter to filter_string in getter functions. #470
  • Detached the ReportFormats API calls from the GMP class into a new ReportFormatsMixin. #470
  • Detached the Roles API calls from the GMP class into a new RolesMixin. #470
  • Detached the Tickets API calls from the GMP class into a new TicketsMixin. #470

Why:

How:

Checklist:

@codecov
Copy link

codecov bot commented May 20, 2021

Codecov Report

Merging #470 (a3bacf6) into master (af96e13) will decrease coverage by 0.20%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #470      +/-   ##
==========================================
- Coverage   97.91%   97.70%   -0.21%     
==========================================
  Files          45       46       +1     
  Lines        3780     3792      +12     
  Branches        0      926     +926     
==========================================
+ Hits         3701     3705       +4     
+ Misses         79       73       -6     
- Partials        0       14      +14     
Impacted Files Coverage Δ
gvm/protocols/gmpv208/entities/audits.py 100.00% <100.00%> (ø)
gvm/protocols/gmpv208/entities/filter.py 100.00% <100.00%> (ø)
gvm/protocols/gmpv208/entities/port_lists.py 100.00% <100.00%> (+1.08%) ⬆️
gvm/protocols/gmpv208/entities/report_formats.py 100.00% <100.00%> (ø)
gvm/protocols/gmpv208/entities/roles.py 100.00% <100.00%> (ø)
gvm/protocols/gmpv208/entities/targets.py 100.00% <100.00%> (ø)
gvm/protocols/gmpv208/entities/tasks.py 100.00% <100.00%> (ø)
gvm/protocols/gmpv208/entities/tickets.py 100.00% <100.00%> (ø)
gvm/protocols/gmpv208/entities/tls_certificates.py 100.00% <100.00%> (ø)
gvm/protocols/gmpv208/entities/users.py 100.00% <100.00%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af96e13...a3bacf6. Read the comment docs.

@y0urself y0urself changed the title [Refactor python-gvm API] Step 2: Detach ReportFormat, Ticket, Role, Group [Refactor python-gvm API] Step 2: Detach ReportFormat, Ticket, Roles May 20, 2021
@y0urself y0urself marked this pull request as ready for review May 20, 2021 14:30
@y0urself y0urself requested a review from a team May 20, 2021 14:30
@y0urself y0urself enabled auto-merge May 20, 2021 14:31
@y0urself y0urself requested a review from bjoernricks May 21, 2021 06:13
@y0urself y0urself merged commit 1471912 into greenbone:master May 21, 2021
@y0urself y0urself deleted the detach-rest branch October 9, 2021 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants