-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GMP get_license and modify_license #1642
Conversation
These commands are meant to be used to get information about the current GSM license and to upload a new license file. This commit only adds dummy functions.
This adds documentation for the functions buffer_license_feature_xml buffer_license_limit_xml, buffer_license_key_xml and buffer_license_signature_xml used to traverse GTrees storing license info with arbitrary key names.
This adds documentation for buffer_license_content_xml, modify_license and manage_get_license.
The "customer" tag was previously named "customer_name" and signature "info_item" elements had the wrong closing tag.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just should be adjusted for the specification changes. I've already marked the relevant changes but not at all places.
The GMP command is changed to fit the current specification, which includes the following changes: - meta fields schema_version and license_type are renamed to version and type - the hardware element is renamed to appliance and the fields cpu_cores and memory are removed, while the sensor field is added - the sections features and limits are removed - the signature section is renamed to signatures and its subelements to signature - the file element of the response is removed
c87517e
to
5b274d1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some small doc changes should be done. Looks good.
Update doc strings for GSM model and model type
What:
These commands are meant to be used to get information about the
current GSM license and to upload a new license file.
This commit only adds dummy functions.
Why:
The new commands will allow managing licenses for Greenbone
appliances via GSA.
AP-1568
How did you test it:
Checklist: