Include new ssh elevate credential login data in OSP request #1539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in manage.c: Appended the ssh elevate login data to the login data of the target osp ssh credential in function target_osp_ssh_credential().
in manage.c: Removed the erroneous type check for the ssh credential in function target_osp_ssh_credential() before appending ssh elevate credential login data to the ssh credential login data.
timopollmeier
requested changes
Jun 1, 2021
in manage.c: Added the two missing free(osp_credential) calls in function target_osp_ssh_credential(..).
in manage.c: Changed the call of free(osp_credential) to osp_credential_free(osp_credential) in function target_osp_ssh_credential(..).
timopollmeier
approved these changes
Jun 2, 2021
|
@Mergifyio refresh |
|
Command
|
jhelmold
added a commit
that referenced
this pull request
Jun 2, 2021
timopollmeier
added a commit
that referenced
this pull request
Jun 2, 2021
Include new ssh elevate credential login data in OSP request (backport #1539)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Appended the ssh elevate login data to the login
data of the target osp ssh credential in function
target_osp_ssh_credential() in manage.c.
Why:
A customer requested the new functionality.
How did you test it:
Checklist: