Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Pull Request template #2417

Merged
merged 2 commits into from
Aug 24, 2020
Merged

Update Pull Request template #2417

merged 2 commits into from
Aug 24, 2020

Conversation

bjoernricks
Copy link
Contributor

What:

Try to improve the quality of information being put into pull requests.

Why:

Often the PR only contains the what part. Sometimes also the why part.
But never the how part.

How:

Sadly the new PR template can only be tested after the PR got merged.

Checklist:

Try to improve the quality of information being put into pull requests.
Often the PR only contains the what part. Sometimes also the why part.
But never the how part.
@bjoernricks bjoernricks requested a review from a team August 24, 2020 07:15
@codecov
Copy link

codecov bot commented Aug 24, 2020

Codecov Report

Merging #2417 into master will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2417      +/-   ##
==========================================
- Coverage   54.96%   54.89%   -0.07%     
==========================================
  Files        1094     1093       -1     
  Lines       26573    26603      +30     
  Branches     7537     7570      +33     
==========================================
- Hits        14605    14603       -2     
- Misses      10862    10895      +33     
+ Partials     1106     1105       -1     
Impacted Files Coverage Δ
gsa/src/web/pages/alerts/component.js 19.08% <0.00%> (-3.14%) ⬇️
gsa/src/web/pages/alerts/dialog.js 20.33% <0.00%> (-0.85%) ⬇️
gsa/src/web/utils/stateReducer.js

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38503cb...93d2a0c. Read the comment docs.

@bjoernricks bjoernricks merged commit 119b029 into greenbone:master Aug 24, 2020
@bjoernricks bjoernricks deleted the improve-pr-template branch August 24, 2020 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants