Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Edge <= 18 support #2408

Merged
merged 2 commits into from
Aug 20, 2020
Merged

Drop Edge <= 18 support #2408

merged 2 commits into from
Aug 20, 2020

Conversation

swaterkamp
Copy link
Member

d3-shape 2.0 and d3-color 2.0 are using ES6 and with the merge of those new dependency versions we will also drop support for the outdated Edge 18 and older versions.

Checklist:

@swaterkamp swaterkamp requested review from sarahd93 and a team August 20, 2020 14:04
@swaterkamp swaterkamp self-assigned this Aug 20, 2020
@codecov
Copy link

codecov bot commented Aug 20, 2020

Codecov Report

Merging #2408 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2408      +/-   ##
==========================================
+ Coverage   54.89%   54.90%   +0.01%     
==========================================
  Files        1093     1093              
  Lines       26603    26603              
  Branches     7538     7538              
==========================================
+ Hits        14603    14606       +3     
+ Misses      10895    10892       -3     
  Partials     1105     1105              
Impacted Files Coverage Δ
gsa/src/web/entities/container.js 45.71% <0.00%> (+1.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c97dc5...d10a103. Read the comment docs.

@swaterkamp swaterkamp merged commit ff35657 into greenbone:master Aug 20, 2020
@swaterkamp swaterkamp deleted the noEdge18 branch August 20, 2020 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants