-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor alert component and alert dialog into function component #2406
Conversation
3d1db66
to
7ca0150
Compare
Codecov Report
@@ Coverage Diff @@
## master #2406 +/- ##
==========================================
+ Coverage 54.89% 54.97% +0.08%
==========================================
Files 1093 1094 +1
Lines 26603 26573 -30
Branches 7570 7537 -33
==========================================
+ Hits 14603 14608 +5
+ Misses 10895 10859 -36
- Partials 1105 1106 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The whole alert dialog and it's state handling is still way to difficult and hard to understand. I really think we need to come up with a new concept for the alert dialog in future.
Checklist: