Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor alert component and alert dialog into function component #2406

Merged
merged 12 commits into from
Aug 24, 2020

Conversation

saberlynx
Copy link
Contributor

Checklist:

@codecov
Copy link

codecov bot commented Aug 20, 2020

Codecov Report

Merging #2406 into master will increase coverage by 0.08%.
The diff coverage is 24.10%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2406      +/-   ##
==========================================
+ Coverage   54.89%   54.97%   +0.08%     
==========================================
  Files        1093     1094       +1     
  Lines       26603    26573      -30     
  Branches     7570     7537      -33     
==========================================
+ Hits        14603    14608       +5     
+ Misses      10895    10859      -36     
- Partials     1105     1106       +1     
Impacted Files Coverage Δ
gsa/src/web/pages/alerts/dialog.js 21.18% <1.44%> (+0.84%) ⬆️
gsa/src/web/utils/stateReducer.js 14.28% <14.28%> (ø)
gsa/src/web/pages/alerts/component.js 22.22% <37.81%> (+3.13%) ⬆️
gsa/src/web/entities/container.js 45.71% <0.00%> (+1.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9b7662...3f123a0. Read the comment docs.

@saberlynx saberlynx marked this pull request as ready for review August 20, 2020 11:59
@saberlynx saberlynx requested review from a team and bjoernricks August 20, 2020 11:59
Copy link
Contributor

@bjoernricks bjoernricks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The whole alert dialog and it's state handling is still way to difficult and hard to understand. I really think we need to come up with a new concept for the alert dialog in future.

@saberlynx saberlynx merged commit 38503cb into greenbone:master Aug 24, 2020
@saberlynx saberlynx deleted the refactor-alerts branch August 24, 2020 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants