APIM 8941 fix closed subscription check #11027
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phiz71
reviewed
Mar 11, 2025
...main/java/io/gravitee/rest/api/management/v2/rest/resource/api/ApiSubscriptionsResource.java
Outdated
Show resolved
Hide resolved
mukul-tyagi08
force-pushed
the
APIM-8941-fix-closed-subscription-check
branch
3 times, most recently
from
594825b to
60ae7b2
Compare
mukul-tyagi08
force-pushed
the
APIM-8941-fix-closed-subscription-check
branch
from
60ae7b2 to
a819846
Compare
phiz71
requested changes
Mar 12, 2025
Comment on lines
+160
to
+181
| @Test | ||
| public void should_return_400_if_subscription_is_closed() { | ||
| final SubscriptionEntity subscriptionEntity = SubscriptionFixtures | ||
| .aSubscriptionEntity() | ||
| .toBuilder() | ||
| .id(SUBSCRIPTION) | ||
| .api("ANOTHER-API") | ||
| .status(SubscriptionStatus.CLOSED) | ||
| .build(); | ||
|
|
||
| when(subscriptionService.findById(SUBSCRIPTION)).thenReturn(subscriptionEntity); | ||
|
|
||
| final Response response = rootTarget().request().post(Entity.json(SubscriptionFixtures.aRenewApiKey())); | ||
| assertEquals(BAD_REQUEST_400, response.getStatus()); | ||
|
|
||
| var error = response.readEntity(Error.class); | ||
| assertEquals(BAD_REQUEST_400, (int) error.getHttpStatus()); | ||
| assertEquals("Subscription [my-subscription] should be paused or accepted. Currently it is CLOSED", error.getMessage()); | ||
|
|
||
| verify(subscriptionService, never()).pause(any(), any()); | ||
| } | ||
|
|
There was a problem hiding this comment.
If you want to keep this test, you will have to mock apikeyservice so it returns an exception.
There was a problem hiding this comment.
Can you add a test here for the new exception?
mukul-tyagi08
force-pushed
the
APIM-8941-fix-closed-subscription-check
branch
from
a819846 to
f4ee306
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
https://gravitee.atlassian.net/browse/APIM-8941
Description
Closed subscription check when renewing api key. For UI we remove the button but for curl or direct request we need this check.
Additional context