Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash in node when mixing sync/async resolvers (backport of #3529) #3573

Closed

Conversation

chrskrchr
Copy link
Contributor

@chrskrchr chrskrchr commented May 11, 2022

This is a backport of #3529 #3651 to the 15.x branch that fixes #3528.

Full credit to @asztal for identifying the fix and submitting the original PR.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented May 11, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

@chrskrchr
Copy link
Contributor Author

Working through the CLA authorization now.

@@ -0,0 +1,51 @@
import { expect } from 'chai';
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backported and stripped type information from this module on main:

https://github.com/graphql/graphql-js/blob/main/src/__testUtils__/expectJSON.ts

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In v15 you don't need this standard expect should work fine.
See other test cases in the same file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! fixed in the latest commit

@chrskrchr
Copy link
Contributor Author

Moving this PR back to draft while I sort out the typing issues.

Copy link
Member

@IvanGoncharov IvanGoncharov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also please backport it to v16.
It would be strange to have this fix in v15 and v17 but not v16 :)

@@ -0,0 +1,51 @@
import { expect } from 'chai';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In v15 you don't need this standard expect should work fine.
See other test cases in the same file.

@chrskrchr chrskrchr marked this pull request as ready for review May 11, 2022 18:02
@chrskrchr
Copy link
Contributor Author

Also please backport it to v16. It would be strange to have this fix in v15 and v17 but not v16 :)

Thanks for the heads up! I wasn't aware that main had moved on to v17. Submitted a similar PR for 16.x.x here:

#3576

@chrskrchr chrskrchr requested a review from IvanGoncharov May 11, 2022 18:08
@IvanGoncharov IvanGoncharov added the PR: bug fix 🐞 requires increase of "patch" version number label May 11, 2022
@chrskrchr
Copy link
Contributor Author

@IvanGoncharov - I finally worked through the EasyCLA issues, would you mind taking another look at this PR?

@chrskrchr
Copy link
Contributor Author

Closing this and re-submitting as a new PR per the guidance in #3651.

@chrskrchr chrskrchr closed this Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: bug fix 🐞 requires increase of "patch" version number
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants