-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix crash in node when mixing sync/async resolvers (backport of #3529) #3573
Conversation
Working through the CLA authorization now. |
src/__testUtils__/expectJSON.js
Outdated
@@ -0,0 +1,51 @@ | |||
import { expect } from 'chai'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Backported and stripped type information from this module on main
:
https://github.com/graphql/graphql-js/blob/main/src/__testUtils__/expectJSON.ts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In v15 you don't need this standard expect
should work fine.
See other test cases in the same file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks! fixed in the latest commit
Moving this PR back to draft while I sort out the typing issues. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also please backport it to v16.
It would be strange to have this fix in v15 and v17 but not v16 :)
src/__testUtils__/expectJSON.js
Outdated
@@ -0,0 +1,51 @@ | |||
import { expect } from 'chai'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In v15 you don't need this standard expect
should work fine.
See other test cases in the same file.
Thanks for the heads up! I wasn't aware that |
@IvanGoncharov - I finally worked through the EasyCLA issues, would you mind taking another look at this PR? |
Closing this and re-submitting as a new PR per the guidance in #3651. |
This is a backport of
#3529#3651 to the15.x
branch that fixes #3528.Full credit to @asztal for identifying the fix and submitting the original PR.