Implement ScalarValue derive macro
#1025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilslv
added
enhancement
FCM |
# Conflicts: # integration_tests/juniper_tests/src/codegen/mod.rs # juniper/CHANGELOG.md # juniper_codegen/src/lib.rs
# Conflicts: # integration_tests/juniper_tests/src/codegen/mod.rs # integration_tests/juniper_tests/src/codegen/scalar_attr_derive_input.rs # integration_tests/juniper_tests/src/codegen/scalar_attr_type_alias.rs # integration_tests/juniper_tests/src/codegen/scalar_value_transparent.rs # integration_tests/juniper_tests/src/custom_scalar.rs # juniper/CHANGELOG.md # juniper/src/lib.rs # juniper/src/types/scalars.rs # juniper/src/value/scalar.rs # juniper_codegen/src/derive_scalar_value.rs # juniper_codegen/src/graphql_scalar/attr.rs # juniper_codegen/src/graphql_scalar/derive.rs # juniper_codegen/src/graphql_scalar/mod.rs # juniper_codegen/src/lib.rs # juniper_codegen/src/result.rs
tyranron
requested changes
Mar 1, 2022
juniper_codegen/src/lib.rs
Outdated
| @@ -549,6 +550,114 @@ pub fn graphql_scalar(attr: TokenStream, body: TokenStream) -> TokenStream { | |||
| .into() | |||
| } | |||
|
|
|||
| /// `#[derive(GraphQLScalarValue)]` macro for deriving a [`ScalarValue`] | |||
There was a problem hiding this comment.
Then let's name it #[derive(ScalarValue)] directly. There is no sense stopping us from that.
There was a problem hiding this comment.
@tyranron should we also rename attributes from #[graphql(...)] to #[scalar_value(...)]?
There was a problem hiding this comment.
@ilslv I think #[value(...)] will be just OK.
juniper_codegen/src/lib.rs
Outdated
| /// | ||
| /// To derive [`ScalarValue`] on enum you should mark corresponding enum | ||
| /// variants with `as_int`/`as_float`/`as_string`/`into_string`/`as_str`/ | ||
| /// `as_boolean` attributes (names correspond to [`ScalarValue`] required |
There was a problem hiding this comment.
Let's rename as_bool directly in the trait, so it complies with Rust types naming. And remove as_boolean variant totally.
ilslv
changed the title
GraphQLScalarValue derive macroScalarValue derive macro
tyranron
approved these changes
Mar 2, 2022
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Synopsis
After redesign
GraphQLScalarvalue lost ability to deriveScalarValueon enums.Solution
Implement
GraphQLScalarValuederive macro to implementScalarValueon enums.Checklist
Draft:prefixDraft:prefix is removed