Support for Django Rest Framework serializers

[patrick91]

Hello from PyConWeb!

I've been working on an integration for Django Rest Framework, to allow the use of its
serializers as GraphQL mutation.

Let me know if this is something you wanted to be merged into graphene-django :)

It's still a work in progress, but I was able to have a working Mutation from a Serializer, still haven't pushed all the code :)

Ideally the code for the Mutation will look like this:

class MyAwesomeMutation(SerializerMutation):
    class Meta:
        serializer_class = MyAwesomeMutation

SerializerMutation will take are of the rest, defining the fields for the output, the fields for the input and the errors.

TODO:

• converter for the fields
• converter for the serializer
• SerializerMutation base class
• Docs 📝
• Use six to support Python 2
• Add missing fields

thanks @simobasso

[coveralls]

Coverage decreased (-3.8%) to 89.989% when pulling 531c840 on patrick91:feature/rest-framework into afec960 on graphql-python:master.

[coveralls]

Coverage decreased (-3.8%) to 89.989% when pulling 531c840 on patrick91:feature/rest-framework into afec960 on graphql-python:master.

[coveralls]

Coverage decreased (-2.8%) to 91.023% when pulling 3ba9a63 on patrick91:feature/rest-framework into afec960 on graphql-python:master.

[coveralls]

Coverage decreased (-4.1%) to 89.67% when pulling cae5620 on patrick91:feature/rest-framework into afec960 on graphql-python:master.

[coveralls]

Coverage decreased (-4.1%) to 89.67% when pulling cae5620 on patrick91:feature/rest-framework into afec960 on graphql-python:master.

[syrusakbary]

The code looks great!
Might be a good idea to use six for the metaclass (so there is compatibility with Python 2.7).

Once the docs are done, I will help to make all the tests pass in the different environments!

[patrick91]

@syrusakbary thanks!
Shall I make a PR for this one as well? #187

It will allow us to use the latest version of Django Rest Framework and to remove some code :)

[audiolion]

Would this allow for validations to be done with rest framework serializers? I think it would lower the barrier to switching to Graphene from rest framework, really cool stuff!

[coveralls]

Coverage decreased (-3.8%) to 89.99% when pulling 6c2f682 on patrick91:feature/rest-framework into afec960 on graphql-python:master.

[coveralls]

Coverage decreased (-3.2%) to 90.638% when pulling 6c2f682 on patrick91:feature/rest-framework into afec960 on graphql-python:master.

[syrusakbary]

The PR #202 is now merged into master. Now the tests should be passing.
Once the missing fields are added I think it should be safe to merge this one :)

[coveralls]

Coverage decreased (-0.3%) to 92.508% when pulling c389924 on patrick91:feature/rest-framework into 7c52aa3 on graphql-python:master.

[coveralls]

Coverage decreased (-0.3%) to 92.524% when pulling f747102 on patrick91:feature/rest-framework into 7c52aa3 on graphql-python:master.

[coveralls]

Coverage decreased (-0.4%) to 92.423% when pulling 7888fa7 on patrick91:feature/rest-framework into 7c52aa3 on graphql-python:master.

[coveralls]

Coverage decreased (-0.5%) to 92.324% when pulling 5c3306e on patrick91:feature/rest-framework into 7c52aa3 on graphql-python:master.

[coveralls]

Coverage decreased (-0.8%) to 92.004% when pulling 5c3306e on patrick91:feature/rest-framework into 7c52aa3 on graphql-python:master.

[coveralls]

Coverage decreased (-0.8%) to 92.004% when pulling 5c3306e on patrick91:feature/rest-framework into 7c52aa3 on graphql-python:master.

[coveralls]

Coverage decreased (-0.5%) to 92.324% when pulling 5c3306e on patrick91:feature/rest-framework into 7c52aa3 on graphql-python:master.

[syrusakbary]

@patrick91 Great! Let me know once is tested :)

[coveralls]

Coverage decreased (-0.6%) to 92.234% when pulling 93bbc19 on patrick91:feature/rest-framework into 7c52aa3 on graphql-python:master.

[coveralls]

Coverage decreased (-0.6%) to 92.234% when pulling 93bbc19 on patrick91:feature/rest-framework into 7c52aa3 on graphql-python:master.

[coveralls]

Coverage decreased (-0.6%) to 92.234% when pulling 93bbc19 on patrick91:feature/rest-framework into 7c52aa3 on graphql-python:master.

[spockNinja]

I have been testing out this PR on a project and things are going well overall. I have just a couple additions in patrick91#1 -- but I can always make a separate PR to the base fork after this is merged if that's easier.

[patrick91]

Thanks! Did you also find yourself wanting to change the input type's name? Maybe it is something I can add in, but I'm not sure it is needed :)

On Tue, Jul 11, 2017, 9:06 PM Jacob Foster ***@***.***> wrote: I have been testing out this PR on a project and things are going well overall. I have just a couple additions in patrick91#1 <patrick91#1> -- but I can always make a separate PR to the base fork after this is merged if that's easier. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#186 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAotlTzzxVIbf8vdXi5gHVEX1YsC7rDgks5sM8e0gaJpZM4NopiD> .

-- Patrick

[spockNinja]

You mean the static "input" name for the graphene.InputObjectType? It doesn't bother me too much right now, but I could definitely see others being more picky about that.

[abdulhaq-e]

Thanks for your contribution. It's working great so far. Sometimes, one needs to add additional arguments to the serializer when instantiating it. It would be great if the instantiation was moved to a separate method so it can be easily overridden.

[coveralls]

Coverage decreased (-0.5%) to 92.356% when pulling 42e9107 on patrick91:feature/rest-framework into 7c52aa3 on graphql-python:master.

[patrick91]

@abdulhaq-e can you open an issue when this PR is merged? :)

@syrusakbary this is ready to merge! @spockNinja added support for other fields and also nested serializers :)

[abdulhaq-e]

@patrick91 I'll submit a PR once this is merged.