Repair outdated tests, add build on Travis CI #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oleg Höfling <oleg.hoefling@gmail.com>
Signed-off-by: Oleg Höfling <oleg.hoefling@gmail.com>
Signed-off-by: Oleg Höfling <oleg.hoefling@gmail.com>
Signed-off-by: Oleg Höfling <oleg.hoefling@gmail.com>
Signed-off-by: Oleg Höfling <oleg.hoefling@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #13 +/- ##
=======================================
Coverage ? 100%
=======================================
Files ? 3
Lines ? 122
Branches ? 15
=======================================
Hits ? 122
Misses ? 0
Partials ? 0
Continue to review full report at Codecov.
|
suzil
approved these changes
Nov 15, 2019
Cito
added a commit
that referenced
this pull request
Jan 24, 2020
Cito
added a commit
that referenced
this pull request
Jan 24, 2020
|
Thanks a lot. Unfortunately saw your PR too late - I already reformatted everything and made some similar changes. So it was too difficult to merge and I commited the remaining changes manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed failing tests, slightly extended the test suite to achieve 100% metric for line+branch coverage. Added config for build with TravisCI (example build) & coverage reports with Codecov (example report).