Skip to content

[FIX] recurring_consignment: make the module compatible with hr_expense. #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

legalsylvain
Copy link
Member

Rational:
When extra module create a new product view, it generates an error because fiscal_classification has a domain based on company and recurring_consigment

Copy link

codecov bot commented Mar 21, 2025

Codecov Report

Attention: Patch coverage is 25.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 90.01%. Comparing base (a3b6e16) to head (e3472e1).
Report is 49 commits behind head on 16.0.

Files with missing lines Patch % Lines
recurring_consignment/models/product_template.py 25.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             16.0     #191      +/-   ##
==========================================
- Coverage   90.52%   90.01%   -0.51%     
==========================================
  Files         127      127              
  Lines        1530     1542      +12     
  Branches      134      137       +3     
==========================================
+ Hits         1385     1388       +3     
- Misses        108      117       +9     
  Partials       37       37              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Rational:
When extra module create a new product view, it generates an error because fiscal_classification has a domain based on company and recurring_consigment
@legalsylvain legalsylvain force-pushed the 16.0-IMP-recurring_consignment-compatibility-hr_expense branch from d39e445 to e3472e1 Compare March 21, 2025 13:55
@legalsylvain
Copy link
Member Author

Mep du 23/03/2025

/ocabot merge minor

@github-grap-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-191-by-legalsylvain-bump-minor, awaiting test results.

@github-grap-bot github-grap-bot merged commit dbc7ec4 into 16.0 Mar 24, 2025
2 of 4 checks passed
@github-grap-bot
Copy link
Contributor

Congratulations, your PR was merged at 605036a. Thanks a lot for contributing to grap. ❤️

@github-grap-bot github-grap-bot deleted the 16.0-IMP-recurring_consignment-compatibility-hr_expense branch March 24, 2025 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants