Add escrow error output to logging #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you have any example log output from this change? |
|
Yes indeed I do: |
|
hey @grahamgilbert! any thoughts on this one? thank you for your review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When inspecting logs from Crypt, sometimes admins may see:
ERROR: Key escrow unsuccessfulThis is a helpful message, but it only explains half of the story. It would be helpful to log the reason why the key escrow was unsuccessful. This PR adds the captured
errorvalue to the Crypt log(s). The goal of merging this PR would be to provide Crypt administrators broader knowledge about when and why key escrows could fail.