Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Plugin: Run prettier on .config after update #722

Merged
merged 2 commits into from
Feb 8, 2024

Conversation

oshirohugo
Copy link
Contributor

@oshirohugo oshirohugo commented Feb 7, 2024

What this PR does / why we need it:

To correctly format the code added after we update .config content we need to run prettier after it.

Which issue(s) this PR fixes:

Fixes #656

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @grafana/create-plugin@3.6.0-canary.722.008c34a.0
# or 
yarn add @grafana/create-plugin@3.6.0-canary.722.008c34a.0

@oshirohugo oshirohugo requested a review from a team as a code owner February 7, 2024 16:32
@oshirohugo oshirohugo requested review from jackw and removed request for a team February 7, 2024 16:32
Copy link

github-actions bot commented Feb 7, 2024

Hello! 👋 This repository uses Auto for releasing packages using PR labels.

✨ This PR can be merged and will trigger a new minor release.
NOTE: When merging a PR with the release label please avoid merging another PR. For further information see here.

@oshirohugo oshirohugo changed the title Create Plugin: run prettier on .config after update Create Plugin: Run prettier on .config after update Feb 7, 2024
@oshirohugo oshirohugo self-assigned this Feb 7, 2024
@oshirohugo oshirohugo added create-plugin related to the create-plugin tool minor Increment the minor version when merged release Create a release when this pr is merged labels Feb 7, 2024
@jackw jackw removed the create-plugin related to the create-plugin tool label Feb 8, 2024
Copy link
Member

@academo academo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work on this!

Copy link
Collaborator

@leventebalogh leventebalogh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Collaborator

@jackw jackw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@oshirohugo oshirohugo merged commit 45ae785 into main Feb 8, 2024
18 of 21 checks passed
@oshirohugo oshirohugo deleted the run-prettier-on-config-after-update-2 branch February 8, 2024 09:21
@grafana-plugins-platform-bot
Copy link

🚀 PR was released in @grafana/create-plugin@3.6.0, @grafana/plugin-e2e@0.12.0 🚀

@grafana-plugins-platform-bot grafana-plugins-platform-bot bot added the released This issue/pull request has been released. label Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Increment the minor version when merged release Create a release when this pr is merged released This issue/pull request has been released.
Projects
Development

Successfully merging this pull request may close these issues.

Run prettier on .config after update.
4 participants