Create-plugin: Check if inside a plugin directory #706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leventebalogh
added
minor
leventebalogh
requested review from
oshirohugo
and removed request for
a team
1 similar comment
This was referenced Jan 30, 2024
leventebalogh
force-pushed
the
leventebalogh/plugin-dir-error-message
branch
from
50bba8e to
8d661c1
Compare
academo
approved these changes
Feb 1, 2024
|
🚀 PR was released in |
grafana-plugins-platform-bot
bot
added
the
released
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split out from: #702
Builds on: #705
What changed?
This PR adds a check to see if the
updatecommand is running inside a valid plugin directory, and shows an error message if not.Examples
Not a plugin directory (expand for video)
Screen.Recording.2024-01-29.at.14.17.30.mov
@sympatheticmoose for visibility.
📦 Published PR as canary version:
Canary Versions✨ Test out this PR locally via:
npm install @grafana/create-plugin@3.2.0-canary.706.8d661c1.0 # or yarn add @grafana/create-plugin@3.2.0-canary.706.8d661c1.0