create-plugin: updates for ci workflow #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
academo
reviewed
May 11, 2023
academo
approved these changes
May 11, 2023
jackw
added
minor
jackw
added
patch
jackw
reviewed
May 16, 2023
| run: docker-compose up -d | ||
|
|
||
| - name: Run e2e tests | ||
| if: steps.check-for-e2e.outputs.has-e2e == 'true' |
There was a problem hiding this comment.
We need to add id: run-e2e-tests to this step if we want to only upload videos for failing tests.
jackw
reviewed
May 16, 2023
packages/create-plugin/templates/github/ci/.github/workflows/ci.yml
Outdated
Show resolved
Hide resolved
…i.yml Co-authored-by: Jack Westbrook <jack.westbrook@gmail.com>
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR makes the following adjustments:
These are just suggestions and how I've modified my plugins to operate (not all have E2E and build times are slower due to spinning up/down docker)
Which issue(s) this PR fixes:
No issue open currently.
Special notes for your reviewer:
I have these changes active in a panel plugin (an unpublished one)
📦 Published PR as canary version:
Canary Versions✨ Test out this PR locally via:
npm install @grafana/create-plugin@1.3.1-canary.242.272cf0e.0 # or yarn add @grafana/create-plugin@1.3.1-canary.242.272cf0e.0