CreatePlugin: Change default docker image to grafana-enterprise #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ty to configure this value from outside the .config folder.
mckn
added
create-plugin
|
On a related note, grafana's default image is enterprise. |
jackw
approved these changes
Feb 2, 2023
jackw
added
release
|
|
|
🚀 PR was released in |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
We got a question about why the
GF_ENTERPRISE_*environment variables wasn't picked up properly after migrating to thecreate-pluginconfiguration files. The reason for this is that we are using thegrafana/grafanadocker image which doesn't contain the enerprise version of Grafana.This PR will change so that all the docker related configuration that is scaffolded by
create-pluginwill usegrafana/grafana-enterpriseas the default docker image. It also adds a way to configure this without adding any changes to the./configfolder which might cause issues while updating.📦 Published PR as canary version:
Canary Versions✨ Test out this PR locally via:
npm install @grafana/create-plugin@0.10.0-canary.197.f95c2c8.0 # or yarn add @grafana/create-plugin@0.10.0-canary.197.f95c2c8.0