Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Plugin: Update jest config to support Grafana 9.4 packages #188

Merged
merged 2 commits into from
Jan 26, 2023

Conversation

jackw
Copy link
Collaborator

@jackw jackw commented Jan 24, 2023

What this PR does / why we need it:

grafana/grafana/pull/61609 bumps the d3 library to latest to resolve a security vulnerability. However latest d3 only provides an es module which causes jest to complain. This PR updates the list of es modules to make sure it's compiled by swc when jest is run.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@jackw jackw added create-plugin related to the create-plugin tool patch Increment the patch version when merged release Create a release when this pr is merged chore Other changes that don't modify src or test files labels Jan 24, 2023
@jackw jackw added this to the v1.0.0 milestone Jan 24, 2023
@jackw jackw self-assigned this Jan 24, 2023
@jackw jackw added minor Increment the minor version when merged and removed patch Increment the patch version when merged release Create a release when this pr is merged labels Jan 26, 2023
Copy link
Collaborator

@leventebalogh leventebalogh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢🇮🇹

@jackw jackw merged commit bf7d072 into main Jan 26, 2023
@jackw jackw deleted the jackw/create-plugin-jest-d3 branch January 26, 2023 14:14
@grafanabot
Copy link
Contributor

🚀 PR was released in @grafana/create-plugin@0.9.0, @grafana/sign-plugin@0.1.0 🚀

@grafanabot grafanabot added the released This issue/pull request has been released. label Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Other changes that don't modify src or test files create-plugin related to the create-plugin tool minor Increment the minor version when merged released This issue/pull request has been released.
Projects
Development

Successfully merging this pull request may close these issues.

3 participants