Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Plugin: Update Jest to v29 #164

Merged
merged 4 commits into from
Nov 30, 2022
Merged

Create Plugin: Update Jest to v29 #164

merged 4 commits into from
Nov 30, 2022

Conversation

jackw
Copy link
Collaborator

@jackw jackw commented Nov 29, 2022

What this PR does / why we need it:
The version of jest offered with create-plugin is two major versions behind current. This PR updates it to latest (v29) inline with Grafana core.

Which issue(s) this PR fixes:

Fixes #161

Special notes for your reviewer:
I've not tested this yet. Hoping CI can pick up anything obvious first.

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @grafana/create-plugin@0.8.0-canary.164.d94943e.0
# or 
yarn add @grafana/create-plugin@0.8.0-canary.164.d94943e.0

@jackw jackw added dependencies Update one or more dependencies version create-plugin related to the create-plugin tool minor Increment the minor version when merged release Create a release when this pr is merged chore Other changes that don't modify src or test files labels Nov 29, 2022
@jackw jackw self-assigned this Nov 29, 2022
Copy link
Collaborator

@leventebalogh leventebalogh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

(Haven't tested it locally, just based on the code.)

@leventebalogh
Copy link
Collaborator

Actually, just tested it out and it didn't work for me unfortunately (latest published version works):

Screenshot 2022-11-30 at 10 33 45

@leventebalogh
Copy link
Collaborator

leventebalogh commented Nov 30, 2022

Another thing that is not directly related to this PR but maybe something we should include in our "What's next?" paragraph.
Once I generated the plugin, did yarn install and try to run yarn test it fails due to not having Git initialised.

--watch is not supported without git/hg

We could either just use --watchAll instead of --watch --onlyChanged, or we can add a point in the "What's next?" section to raise their attention to initialise Git before doing anything else. WDYT?

@jackw
Copy link
Collaborator Author

jackw commented Nov 30, 2022

Thanks for taking the time to test this out @leventebalogh really appreciate it. I've pushed a couple of commits that should fix the errors with tests and improve our success messaging...

Screenshot 2022-11-30 at 12 37 03

@jackw jackw merged commit 1587024 into main Nov 30, 2022
@jackw jackw deleted the jackw/bump-jest-29 branch November 30, 2022 14:25
@grafanabot
Copy link
Contributor

🚀 PR was released in @grafana/create-plugin@0.8.0 🚀

@grafanabot grafanabot added the released This issue/pull request has been released. label Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Other changes that don't modify src or test files create-plugin related to the create-plugin tool dependencies Update one or more dependencies version minor Increment the minor version when merged release Create a release when this pr is merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Plugin: Update to Jest 29
3 participants