-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create Plugin: Update Jest to v29 #164
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
(Haven't tested it locally, just based on the code.)
Another thing that is not directly related to this PR but maybe something we should include in our "What's next?" paragraph.
We could either just use |
Thanks for taking the time to test this out @leventebalogh really appreciate it. I've pushed a couple of commits that should fix the errors with tests and improve our success messaging... |
🚀 PR was released in |
What this PR does / why we need it:
The version of jest offered with create-plugin is two major versions behind current. This PR updates it to latest (v29) inline with Grafana core.
Which issue(s) this PR fixes:
Fixes #161
Special notes for your reviewer:
I've not tested this yet. Hoping CI can pick up anything obvious first.
📦 Published PR as canary version:
Canary Versions
✨ Test out this PR locally via:
npm install @grafana/create-plugin@0.8.0-canary.164.d94943e.0 # or yarn add @grafana/create-plugin@0.8.0-canary.164.d94943e.0