Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Updates Scenes templates #1538

Merged
merged 1 commit into from
Feb 14, 2025
Merged

Conversation

hugohaggmark
Copy link
Contributor

@hugohaggmark hugohaggmark commented Feb 12, 2025

What this PR does / why we need it:
This PR updates the Scenes template files so they use the latest Scenes API and are more inline with the documentation

Which issue(s) this PR fixes:

Fixes #1522

Special notes for your reviewer:

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @grafana/create-plugin@5.17.0-canary.1538.13281106940.0
npm install @grafana/eslint-plugin-plugins@0.2.0-canary.1538.13281106940.0
# or 
yarn add @grafana/create-plugin@5.17.0-canary.1538.13281106940.0
yarn add @grafana/eslint-plugin-plugins@0.2.0-canary.1538.13281106940.0

@hugohaggmark hugohaggmark requested a review from a team as a code owner February 12, 2025 08:28
@hugohaggmark hugohaggmark requested a review from academo February 12, 2025 08:28
@hugohaggmark hugohaggmark added minor Increment the minor version when merged release Create a release when this pr is merged labels Feb 12, 2025
Copy link

github-actions bot commented Feb 12, 2025

Hello! 👋 This repository uses Auto for releasing packages using PR labels.

✨ This PR can be merged and will trigger a new minor release.
NOTE: When merging a PR with the release label please avoid merging another PR. For further information see here.

@hugohaggmark hugohaggmark added the create-plugin related to the create-plugin tool label Feb 12, 2025
@hugohaggmark hugohaggmark requested review from jackw and removed request for academo February 13, 2025 07:35
Copy link
Collaborator

@mckn mckn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@jackw jackw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@hugohaggmark hugohaggmark merged commit 8eb0c89 into main Feb 14, 2025
20 of 21 checks passed
@hugohaggmark hugohaggmark deleted the hugoh/refactor-scenes-app branch February 14, 2025 04:49
@grafana-plugins-platform-bot
Copy link

🚀 PR was released in @grafana/create-plugin@5.17.0, @grafana/plugin-meta-extractor@0.4.0 🚀

@grafana-plugins-platform-bot grafana-plugins-platform-bot bot added the released This issue/pull request has been released. label Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
create-plugin related to the create-plugin tool minor Increment the minor version when merged release Create a release when this pr is merged released This issue/pull request has been released.
Projects
Development

Successfully merging this pull request may close these issues.

Feat: Update Scenes templates to use latest APIs
3 participants