Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create-Plugin: Add errors with status code in backend template #153

Merged
merged 4 commits into from
Nov 24, 2022

Conversation

xnyo
Copy link
Member

@xnyo xnyo commented Nov 18, 2022

What this PR does / why we need it:

  • grafana-plugin-sdk-go to v0.143.0, which adds support for status codes in DataResponse
  • Edits the backend template to demonstrate how to return errors in a DataResponse

Which issue(s) this PR fixes:

Fixes #141

Special notes for your reviewer:

NA

@xnyo xnyo added enhancement New feature or request create-plugin related to the create-plugin tool labels Nov 18, 2022
@xnyo xnyo self-assigned this Nov 18, 2022
@xnyo xnyo changed the title Create-Plugin: Add errors with status code in backend example Create-Plugin: Add errors with status code in backend template Nov 22, 2022
@xnyo xnyo marked this pull request as ready for review November 23, 2022 11:14
@xnyo xnyo requested review from wbrowne and mckn November 23, 2022 11:14
Copy link
Collaborator

@mckn mckn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@xnyo xnyo merged commit a041242 into main Nov 24, 2022
@xnyo xnyo deleted the giuseppe/141-backend-example-207-status branch November 24, 2022 11:25
@grafanabot
Copy link
Contributor

🚀 PR was released in @grafana/create-plugin@0.6.2 🚀

@grafanabot grafanabot added the released This issue/pull request has been released. label Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
create-plugin related to the create-plugin tool enhancement New feature or request released This issue/pull request has been released.
Projects
Development

Successfully merging this pull request may close these issues.

Enhancement: Add query data error handling to datasource backend template
4 participants