Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create-Plugin: Update grafanaVersion to 9.2.5 #149

Merged
merged 1 commit into from
Nov 18, 2022

Conversation

jackw
Copy link
Collaborator

@jackw jackw commented Nov 17, 2022

What this PR does / why we need it:
This PR updates create-plugin to use the latest version of @grafana packages when scaffolding a new plugin.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:
Given we do a release once a week I'm not sure about how feasible it is to manage the grafana version in this way. Another option is to use the latest keyword so a plugin dev will always get the latest version of the packages however I'm a little loathed to do that right now as I worry we won't be able to easily understand if the templates work with the latest version of packages. 🤔

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @grafana/create-plugin@0.5.5-canary.149.2ff8049.0
# or 
yarn add @grafana/create-plugin@0.5.5-canary.149.2ff8049.0

@jackw jackw added create-plugin related to the create-plugin tool patch Increment the patch version when merged labels Nov 17, 2022
@jackw jackw requested review from mckn and leventebalogh November 17, 2022 15:28
@jackw jackw self-assigned this Nov 17, 2022
@jackw jackw added the release Create a release when this pr is merged label Nov 17, 2022
@jackw jackw force-pushed the jackw/latest-grafana-version branch from 3be4282 to 2ff8049 Compare November 18, 2022 09:02
Copy link
Collaborator

@mckn mckn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jackw jackw merged commit b996425 into main Nov 18, 2022
@jackw jackw deleted the jackw/latest-grafana-version branch November 18, 2022 10:26
@grafanabot
Copy link
Contributor

🚀 PR was released in @grafana/create-plugin@0.6.1 🚀

@grafanabot grafanabot added the released This issue/pull request has been released. label Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
create-plugin related to the create-plugin tool patch Increment the patch version when merged release Create a release when this pr is merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants