Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref: set testdata-db DS for panel plugin #1282

Merged
merged 4 commits into from
Nov 7, 2024
Merged

ref: set testdata-db DS for panel plugin #1282

merged 4 commits into from
Nov 7, 2024

Conversation

s4kh
Copy link
Contributor

@s4kh s4kh commented Oct 31, 2024 •
edited
Loading

What this PR does / why we need it:

Configures TestData DB for provisioned panel dashboard .

Which issue(s) this PR fixes:

Fixes #1112
Fixes https://github.com/grafana/grafana-community-team/issues/243

Screenshot from 2024-10-31 10-22-01

@s4kh s4kh requested a review from a team as a code owner October 31, 2024 14:25
@s4kh s4kh requested review from mckn and removed request for a team October 31, 2024 14:25
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 31, 2024 •
edited
Loading

Hello! 👋 This repository uses Auto for releasing packages using PR labels.

✨ This PR can be merged but will not trigger a new release. To trigger a new release add the release label before merging.
NOTE: When merging a PR with the release label please avoid merging another PR. For further information see here.

@s4kh s4kh added the minor Increment the minor version when merged label Oct 31, 2024
@s4kh s4kh force-pushed the feat-default-datasource branch from 6cef482 to 9577d11 Compare October 31, 2024 14:27
@s4kh
Copy link
Contributor Author

s4kh commented Oct 31, 2024

@jackw For the dashboard, we also have https://github.com/grafana/plugin-tools/pull/1282/files#diff-f5a693e0319d1b6e0c9ae180ebcb1aa6241150e9a48377120ec138f303ea91b2R81 config for same panel but scenarioId:no_data_points. Should we change this as well?

@s4kh s4kh requested a review from jackw October 31, 2024 14:29
@s4kh
Copy link
Contributor Author

s4kh commented Oct 31, 2024 •
edited
Loading

@tolzhabayev @jackw
One thing I noticed is if I change the scenario to something else and comeback again at Raw Frame the data is lost, refreshing the page populates the data. It seems the expected behaviour.

It doesn't (maybe should not) add a different scenario within the query, is only replaced - using index with the changed scenario.
Change - https://github.com/grafana/grafana/blob/main/public/app/features/query/components/QueryEditorRows.tsx#L50
Change scenario - https://github.com/grafana/grafana/blob/main/public/app/plugins/datasource/grafana-testdata-datasource/QueryEditor.tsx#L87

@s4kh s4kh force-pushed the feat-default-datasource branch from b364c0d to 0030cf9 Compare November 2, 2024 00:36
@s4kh s4kh force-pushed the feat-default-datasource branch from 0030cf9 to 5267bb0 Compare November 2, 2024 00:47
@s4kh s4kh force-pushed the feat-default-datasource branch from 5267bb0 to f908da1 Compare November 2, 2024 00:52
@s4kh s4kh requested review from xnyo, josmperez and academo November 4, 2024 14:13
mckn
mckn approved these changes Nov 6, 2024
View reviewed changes
Copy link
Collaborator

@mckn mckn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work with this! LGTM

josmperez
josmperez approved these changes Nov 7, 2024
View reviewed changes
Copy link
Contributor

@josmperez josmperez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, nice additions. I've made a commit with some suggestions mostly for Grafana style and clarity. Please take a look and approve if they make sense to you.

xnyo
xnyo approved these changes Nov 7, 2024
View reviewed changes
Copy link
Member

@xnyo xnyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@s4kh s4kh merged commit dded9c0 into main Nov 7, 2024
12 checks passed
@s4kh s4kh deleted the feat-default-datasource branch November 7, 2024 14:12
@grafana-plugins-platform-bot
Copy link

🚀 PR was released in @grafana/create-plugin@5.9.0, @grafana/plugin-e2e@1.12.0, website@3.5.0 🚀

@grafana-plugins-platform-bot grafana-plugins-platform-bot bot added the released This issue/pull request has been released. label Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mckn mckn mckn approved these changes

@xnyo xnyo xnyo approved these changes

@josmperez josmperez josmperez approved these changes

@jackw jackw Awaiting requested review from jackw

@academo academo Awaiting requested review from academo

Assignees
No one assigned
Labels
minor Increment the minor version when merged released This issue/pull request has been released.
Projects
Plugins Platform / Grafana Community
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feat: Replace random walk in provisioned panel dashboard
4 participants
@s4kh @mckn @xnyo @josmperez