Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Datasources: Add fixed width to name field in config editor #84970

Merged
merged 1 commit into from
Mar 26, 2024
Merged

Datasources: Add fixed width to name field in config editor #84970

merged 1 commit into from
Mar 26, 2024

Conversation

sunker
Copy link
Contributor

@sunker sunker commented Mar 22, 2024

What is this feature?

By fixating the width of this field, we at least give data sources a chance to align label width in the fields used in the config editor so that it looks better.

Why do we need this feature?

[Add a description of the problem the feature is trying to solve.]

Who is this feature for?

[Add information on what kind of user the feature is for.]

Which issue(s) does this PR fix?:

Fixes #

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@sunker sunker requested review from mikkancso and a team as code owners March 22, 2024 07:54
@sunker sunker requested review from oshirohugo and removed request for a team March 22, 2024 07:54
@grafana-delivery-bot grafana-delivery-bot bot added this to the 11.0.x milestone Mar 22, 2024
@sunker sunker changed the title Datasources: Add fixed width to name field Datasources: Add fixed width to name field in config editor Mar 22, 2024
@sunker sunker mentioned this pull request Mar 22, 2024
Merged
@sunker sunker requested a review from a team March 25, 2024 14:28
mckn
mckn approved these changes Mar 26, 2024
View reviewed changes
Copy link
Contributor

@mckn mckn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sunker sunker merged commit 28ecd83 into main Mar 26, 2024
24 checks passed
@sunker sunker deleted the datasources/name-field-fixed-width branch March 26, 2024 09:13
@grafana-delivery-bot grafana-delivery-bot bot modified the milestones: 11.0.x, 11.1.x Mar 26, 2024
@ashharrison90 ashharrison90 modified the milestones: 11.1.x, 11.0.0-preview Apr 15, 2024
@ashharrison90 ashharrison90 added product-approved Pull requests that are approved by product/managers and are allowed to be backported backport v11.0.x Mark PR for automatic backport to v11.0.x labels Apr 15, 2024
grafana-delivery-bot bot pushed a commit that referenced this pull request Apr 15, 2024
@sunker @grafana-delivery-bot
Datasources: Add fixed width to name field in config editor (#84970)
b0785a4 
add fixed width to name field

(cherry picked from commit 28ecd83)
@grafana-delivery-bot grafana-delivery-bot bot mentioned this pull request Apr 15, 2024
Merged
3 tasks
ashharrison90 pushed a commit that referenced this pull request Apr 15, 2024
@grafana-delivery-bot @sunker
[v11.0.x] Datasources: Add fixed width to name field in config editor (…
3aba1ad 
…#86179)

Datasources: Add fixed width to name field in config editor (#84970)

add fixed width to name field

(cherry picked from commit 28ecd83)

Co-authored-by: Erik Sundell <erik.sundell87@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mckn mckn mckn approved these changes

@mikkancso mikkancso Awaiting requested review from mikkancso

@oshirohugo oshirohugo Awaiting requested review from oshirohugo oshirohugo is a code owner automatically assigned from grafana/plugins-platform-frontend

Assignees
No one assigned
Labels
add to changelog area/frontend backport v11.0.x Mark PR for automatic backport to v11.0.x product-approved Pull requests that are approved by product/managers and are allowed to be backported
Projects
None yet
Milestone
11.0.0-preview
Development

Successfully merging this pull request may close these issues.
3 participants
@sunker @mckn @ashharrison90