Add Type to DataSourceInstanceSettings #490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toddtreece
requested review from
wbrowne and
marefr
and removed request for
a team
marefr
suggested changes
Apr 19, 2022
wbrowne
approved these changes
Apr 19, 2022
marefr
reviewed
Apr 19, 2022
toddtreece
commented
Apr 19, 2022
sd2k
added a commit
to grafana/grafana-plugin-sdk-rust
that referenced
this pull request
Apr 29, 2022
This replicates the functionality added to the Go SDK in grafana/grafana-plugin-sdk-go#490.
sd2k
added a commit
to grafana/grafana-plugin-sdk-rust
that referenced
this pull request
Jun 1, 2022
This replicates the functionality added to the Go SDK in grafana/grafana-plugin-sdk-go#490.
sd2k
added a commit
to grafana/grafana-plugin-sdk-rust
that referenced
this pull request
Jun 6, 2022
This replicates the functionality added to the Go SDK in grafana/grafana-plugin-sdk-go#490.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This adds
TypetoDataSourceInstanceSettingsin order to support the change suggested here.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: