fix: more than one source types found for dashboard #991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mmd-afegbua could you check if this pr solves #964? |
hubeadmin
approved these changes
Apr 14, 2023
|
Seems like this fixes solved the issue. Thanks @weisdd |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, a dashboard hash would be calculated from
cr.Spec.Json. To make sure hash is calculated for dashboards coming from any sources, a simple trick was used:cr.Spec.Json = string(dashboardJson). That wasn't an issue with a single Grafana instance, but seems to be so with multiple instances.The suggested PR removes that trick and makes sure hash is calculated explicitly. I think it should be either in
onDashboardCreatedorr.fetchDashboardJson, I can move it around if needed.Closes: #964