fix: double-lock when multiple dashboards have the same UID #864
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As it was described in #860, controller tries to acquire a second lock (and, thus, gets stuck) when there are multiple dashboards with the same UID and one of those gets deleted.
The issue is that
Lock()
is called from within the for loop, so the fix simply requires the lock to be moved outside of the loop.Additional changes:
Not sure why dashboard references with a particular uid would get removed for all namespaces, not just the one matching the delete request:
=> I fixed that, though, please, let me know if the behaviour was intentional;
RemovePluginsFor()
didn't have lock:=> Added the lock.
Relevant issues/tickets
Closes: #860
Type of change
Checklist
Verification steps
Follow the steps described in #860: