Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Azure monitoring fields for grafanadatasources #293

Merged
merged 3 commits into from
Oct 19, 2020

Conversation

hubeadmin
Copy link
Collaborator

@hubeadmin hubeadmin commented Oct 15, 2020

Description

  • Adds new fields for Azure monitoring

Relevant issues/tickets

#268

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • This change requires a documentation update
  • I have added tests that prove my fix is effective or that my feature works
  • I have added a test case that will be used to verify my changes
  • Verified independently on a cluster by reviewer

Verification steps

Would require a running azure instance, which I currently do not have access to, going off Grafana documentation here and the fields required by @rbeckerpf

@hubeadmin hubeadmin added the enhancement New feature or request label Oct 15, 2020
@hubeadmin hubeadmin requested a review from pb82 October 15, 2020 09:08
@pb82 pb82 merged commit dca10dc into grafana:master Oct 19, 2020
@hubeadmin hubeadmin deleted the fix-286 branch November 5, 2020 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants