-
Notifications
You must be signed in to change notification settings - Fork 415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(GrafanaAlertRuleGroup): add support for Grafana-managed recording rules #1881
Conversation
Signed-off-by: miinsun <kor3334@naver.com>
ee1ee4b
to
9aaa10b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution!
This functionality is not activated by default in self-hosted / Enterprise Grafana and results in a failure to apply changes by the operator (when Record
is passed).
Thus, it'd be great to have a full example added to examples/
including the feature toggle and related configuration.
Also, an e2e-test would be handy to make sure we catch failures should the Grafana API change in future.
Thanks for your feedback;) Looks like I missed adding the test code. I'll update the PR soon with the example and e2e test as you suggested. |
Signed-off-by: miinsun <kor3334@naver.com>
Signed-off-by: miinsun <kor3334@naver.com>
24ae554
to
f97a428
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@miinsun Thanks for the update. I've pushed a few changes to your branch (feature toggle configuration was missing, test data needed to be added to a different file). For the rest, it should be good to be merged.
@theSuess any closing thoughts? (e.g. whether we should keep the recording rule example in a different folder)
Happy with merging this as-is and updating docs later on |
It was my first time using Chainsaw, and honestly, I struggled with writing test cases. But now I see how it should be done—it looks great! I learned a lot while reviewing your code. Thanks @weisdd |
@sachinjkattoor It's expected to happen today. |
see #1862
I’ve added a new Record type to the GrafanaAlertRuleGroup Spec.
I’ve also updated the controller to handle From and Metric variables within the Record type.
Is there anything else I need to do???
Fixes: #1862