fix(GrafanaDatasource): don't treat missing datasource as an error when deleting datasource

[lexhuismans]

A similar PR as for the issue regarding grafanafolder controller #1516 but for the grafanadatasource controller.

This solves two problems

Datasource removed from Grafana instance but not yet from Grafana CRD

Looks like when we retrieve the ID or try to the delete the resource and we receive an error we only return the exception on NotFound. While we should proceed on NotFound (to delete the resource from the Grafana CRD) and return on any other exception.

This will happen when a datasource is for example manually deleted using the the UI. And will loop forever. Reconciler error

Datasource removed from Grafana CRD when client throws an error

The other side of this is that when an error occurs that is anything but NotFound: if errors.As(err, &notFound) > False > remove datasource the datasource is removed from the Grafana CRD status anyway.

Code

Bug

... 
if errors.As(err, &notFound) {
	return ctrl.Result{}, err
}
...
grafana.Status.Dashboards = grafana.Status.Dashboards.Remove(namespace, name)

// won't remove datasource from Grafana CRD when already removed, e.g. through UI
// will remove datasource from Grafana CRD status list when different error occurs (e.g. Grafana unavailable)

Feature

...
if !errors.As(err, &notFound) {
	return ctrl.Result{}, err
}
...
grafana.Status.Dashboards = grafana.Status.Dashboards.Remove(namespace, name)

// will remove datasource from Grafana CRD when already removed, e.g. through UI
// won't remove datasource from Grafana CRD status list when different error occurs (e.g. Grafana unavailable)

[CLAassistant]

All committers have signed the CLA.

[theSuess]

Good catch! Thanks for the contribution