Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: version image in kustomize #1863

Merged
merged 3 commits into from
Feb 19, 2025
Merged

chore: version image in kustomize #1863

merged 3 commits into from
Feb 19, 2025

Conversation

sentoz
Copy link
Contributor

@sentoz sentoz commented Feb 14, 2025

  • added an indication of the image version in kustomization.yaml
  • added auto installation of image version for customize in Makefile

@CLAassistant
Copy link

CLAassistant commented Feb 14, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the bugfix this PR fixes a bug label Feb 14, 2025
@theSuess
Copy link
Member

Thanks for the contribution!

We perform this version update automatically during our release workflow:
https://github.com/grafana/grafana-operator/blob/master/.github/workflows/release.yaml#L118

Did you encounter issues with our kustomize artifacts or does this solve another issue?

@sentoz
Copy link
Contributor Author

sentoz commented Feb 17, 2025

Thanks for the contribution!

We perform this version update automatically during our release workflow: https://github.com/grafana/grafana-operator/blob/master/.github/workflows/release.yaml#L118

Did you encounter issues with our kustomize artifacts or does this solve another issue?

Not really, unfortunately vanilla kustomize does not support oci, only flux

theSuess
theSuess approved these changes Feb 17, 2025
View reviewed changes
Copy link
Member

@theSuess theSuess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see - in that case, I'm good with merging this!

@theSuess theSuess added chore and removed bugfix this PR fixes a bug labels Feb 17, 2025
@sentoz
Copy link
Contributor Author

sentoz commented Feb 17, 2025

@theSuess

The github limit was triggered there - job

@theSuess theSuess added this pull request to the merge queue Feb 19, 2025
Merged via the queue into grafana:master with commit ae3c268 Feb 19, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theSuess theSuess theSuess approved these changes

@NissesSenap NissesSenap Awaiting requested review from NissesSenap NissesSenap is a code owner

@weisdd weisdd Awaiting requested review from weisdd weisdd is a code owner

@ishanjainn ishanjainn Awaiting requested review from ishanjainn ishanjainn is a code owner

@hubeadmin hubeadmin Awaiting requested review from hubeadmin hubeadmin is a code owner

@pb82 pb82 Awaiting requested review from pb82 pb82 is a code owner

Assignees
No one assigned
Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sentoz @CLAassistant @theSuess