Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add headlessService for grafana high availability #1840

Merged
merged 2 commits into from
Feb 21, 2025

Conversation

synthe102
Copy link
Contributor

This PR implements the steps described in the Grafana documentation to configure a HA grafana:

  • Headless Service
  • Expose port 9094 on the deployment
  • POD_IP environment variable from downward API

While most of it can already be added manually with overrides in the CR, the headless service has to be manually created. I think that providing all the key components to run a HA Grafana makes sense.

The "Multiple replicas" doc example has also been updated to include a config snippet for HA setup.

@CLAassistant
Copy link

CLAassistant commented Jan 29, 2025

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the documentation Issues relating to documentation, missing, non-clear etc. label Jan 29, 2025
@synthe102 synthe102 force-pushed the master branch 3 times, most recently from 939b564 to 6b4d76e Compare January 29, 2025 20:16
@NissesSenap
Copy link
Collaborator

@synthe102 thanks for the PR, could you create some e2e test as well? Just to see that the yaml gets generated as intended

@synthe102
Copy link
Contributor Author

Sure !

@synthe102 synthe102 force-pushed the master branch 2 times, most recently from ed971a5 to 2c6552d Compare January 30, 2025 15:20
Copy link
Member

@theSuess theSuess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed a small reference issue in the update hook, merging once e2e tests pass

@theSuess theSuess added this pull request to the merge queue Feb 21, 2025
Merged via the queue into grafana:master with commit 03534e3 Feb 21, 2025
15 checks passed
@weisdd weisdd added the feature this PR introduces a new feature label Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Issues relating to documentation, missing, non-clear etc. feature this PR introduces a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants