Fix: Apply error condition never registered due to early return #1837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Baarsgaard
force-pushed
the
fix_synchronized_error_condition_missing
branch
from
ee1d36f to
5a7afe3
Compare
Baarsgaard
force-pushed
the
fix_synchronized_error_condition_missing
branch
2 times, most recently
from
2aac88d to
0ef7517
Compare
Baarsgaard
requested review from
NissesSenap,
weisdd,
ishanjainn,
theSuess,
hubeadmin and
pb82
as code owners
Baarsgaard
force-pushed
the
fix_synchronized_error_condition_missing
branch
from
0ef7517 to
4227d2e
Compare
Baarsgaard
force-pushed
the
fix_synchronized_error_condition_missing
branch
from
4227d2e to
441c03a
Compare
theSuess
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I forgot that the
buildSynchronizedConditionfunction applies either a successful or a failed condition depending on whether errors where present.This was noticed by @msvechla in #1800
To ensure something like this never happens again, tests have been added to provoke and test every condition currently implemented.
Future PRs will include conditions and tests for
GrafanaDashboardsand potentiallyGrafanas.Any future CR or condition implementation should probably expand these tests to ensure that the conditions can be provoked appropriately.