Move database field in example to jsonData #1725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With Grafana 9.4, the location for the database field has moved to the jsonData element. While a datasource deployed with the database field in directly on the datasource level still works for existing queries and also auto completion while coding queries works, the query builder is broken for such datasources. See the end of this discussion: grafana/grafana#83833
michael-os
requested review from
NissesSenap,
weisdd,
ishanjainn,
theSuess and
pb82
as code owners
|
|
theSuess
approved these changes
Oct 25, 2024
michael-os
deleted the
update-database-field-in-postgres-datasource-example
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With Grafana 9.4, the location for the database field has moved to the jsonData element (see 1,2). While a datasource deployed with the database field in directly on the datasource level still works for existing queries and also auto completion while coding queries works, the query builder is broken for such datasources.
See the end of the discussion in 3