Improvements to 3 0 2 #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When sending the dashboard id stored in the CR status block it can happen that a dashboard overwrites another: 1) dashboard is imported, id is written back 2) another dashboard with plugins is imported, Grafana is restarted 3) all dashboards are reimported but not the order becomes important: a dashboard with previously no ID in the status block (the one with the plugins) gets imported first and gets the id of the other dashboard with already an id in the status block. 4) afterwards the already imported dashboard is imported again and overwrites the new one.
The strategy for creating URLs based on ingresses should prever the user provided hostname instead of trying to get some auto generated hostname or falling back on the IP.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for #136 and #137
fixes a case where one dashboard could overwrite another if Grafana was restarted (due to plugins) and upon reimport old dashboard IDs (from the status block) were reused.