-
Notifications
You must be signed in to change notification settings - Fork 415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: advanced secret and configmap refs in data sources #1055
Conversation
b494b84
to
d752ed9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
It would be great to have the same feature for dashboards. This would allow to import configmaps matching specific labels, i.e: apiVersion: v1
kind: ConfigMap
metadata:
name: foobar
labels:
grafana_dashboard: '1'
# ... like the grafana helm chart, see here. |
@sathieu we don't plan to support this feature. The CR does things for us and it would add a bunch of extra complexity. You can find an example of this in #999 This way you will have to write a short script that find the configmaps according to your label and create a CR for them, which should be rather straight forward. At the same time it's not that painful to do the same thing and just create a CR according to our standards. |
Thanks for your response @NissesSenap. I don't think I'll be able to contribute such a big feature, which is probably as complex as this PR #1055. |
@sathieu feel free to create an issue around it and we will see how many other users that wants it. |
How can I add dashboards with the label |
This removes the
.spec.secrets
field of data sources and replaces it with a more flexible solution relying on Secret and Config Map Key selectors and path based applying.Thanks @addreas for the initial implementation, this is mostly based on your PR #999