-
Notifications
You must be signed in to change notification settings - Fork 415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify folder controller schema, change folder uid if needed #1039
Conversation
I will take a deeper look tomorrow. I think we also should update some docs to match the changes. Or didn't we add any folder example? |
@NissesSenap unless I overlooked them, we don't have any examples with folders yet. I thought of adding one after permissions are implemented. For basic permissions (just raw json), I have some code already, it's just a bit of extra code on top of the changes from this PR, so I'll park another PR till this one is discussed/reviewed :) |
@weisdd verified and works, folders get created. Manifests need to be udpated though ( |
@pb82 if we want to enforce that we should do it through CI. We let's add that in a separate PR and we can fix all the generation there. |
@pb82 Seems like |
c91924c
to
27c1833
Compare
Thanks @weisdd ! @NissesSenap yes, it would be good to make this part of the pipeline. |
Several improvements for folder controller:
title
in a separate field.onFolderCreated
a bit to make room for further introduction of permissions (those will be in json);uid
if needed (e.g. folder was created outside of operator or through dashboard controller => exists with different uid).