Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Pass Authorization header only to Grafana when using apikey auth #162

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

xnyo
Copy link
Member

@xnyo xnyo commented Jan 23, 2025

Changes the behaviour for apikey authentication so it injects the Authorization header only for requests towards Grafana itself, excluding everything else (Grafana Cloud CDNs).

Fixes #161 and #159.

@xnyo xnyo added the bug Something isn't working label Jan 23, 2025
@xnyo xnyo requested review from tolzhabayev and briangann January 23, 2025 12:08
@xnyo xnyo self-assigned this Jan 23, 2025
Copy link
Collaborator

@briangann briangann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@briangann briangann merged commit 7c94f5c into main Jan 24, 2025
4 checks passed
@briangann briangann deleted the giuseppe/fix-kiosk-auth-apikey branch January 24, 2025 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

Successfully merging this pull request may close these issues.

Avoid adding headers to URL requests that do not require it
2 participants