Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade scala/zinc to 1.10.4 #30892

Merged
merged 4 commits into from
Dec 3, 2024
Merged

upgrade scala/zinc to 1.10.4 #30892

merged 4 commits into from
Dec 3, 2024

Conversation

tnielens
Copy link
Contributor

@tnielens tnielens commented Oct 13, 2024

Upgrades zinc, the scala incremental compiler, to 1.10.2.

Context

Includes compiler avoidance bug fix sbt/zinc#1382 which affects gradle multi project builds.

Contributor Checklist

  • Review Contribution Guidelines.
  • Make sure that all commits are signed off to indicate that you agree to the terms of Developer Certificate of Origin.
  • Make sure all contributed code can be distributed under the terms of the Apache License 2.0, e.g. the code was written by yourself or the original code is licensed under a license compatible to Apache License 2.0.
  • Check "Allow edit from maintainers" option in pull request so that additional changes can be pushed by Gradle team.
  • Provide integration tests (under <subproject>/src/integTest) to verify changes from a user perspective.
  • Provide unit tests (under <subproject>/src/test) to verify logic.
  • Update User Guide, DSL Reference, and Javadoc for public-facing changes.
  • Ensure that tests pass sanity check: ./gradlew sanityCheck.
  • Ensure that tests pass locally: ./gradlew <changed-subproject>:quickTest.

Reviewing cheatsheet

Before merging the PR, comments starting with

  • ❌ ❓must be fixed
  • 🤔 💅 should be fixed
  • 💭 may be fixed
  • 🎉 celebrate happy things

@tnielens tnielens requested a review from a team as a code owner October 13, 2024 19:42
@tnielens tnielens requested a review from jvandort October 13, 2024 19:42
@bot-gradle bot-gradle added from:contributor PR by an external contributor to-triage labels Oct 13, 2024
@tnielens tnielens requested a review from a team as a code owner October 13, 2024 19:45
@tnielens
Copy link
Contributor Author

A test case failure seems to indicate a regression with the zinc upgrade. I'm having a look.

@ov7a

This comment has been minimized.

@bot-gradle
Copy link
Collaborator

I've triggered the following builds:

@ov7a ov7a self-assigned this Oct 15, 2024
@ov7a ov7a removed the to-triage label Oct 15, 2024
@bot-gradle
Copy link
Collaborator

The following builds have failed:

@ov7a
Copy link
Member

ov7a commented Nov 29, 2024

@bot-gradle test this please

@bot-gradle

This comment has been minimized.

@bot-gradle
Copy link
Collaborator

The following builds have failed:

tnielens and others added 2 commits November 29, 2024 16:24
@ov7a ov7a changed the title upgrade scala/zinc to 1.10.2 upgrade scala/zinc to 1.10.4 Nov 29, 2024
@ov7a ov7a marked this pull request as ready for review November 29, 2024 16:59
@ov7a ov7a requested review from a team as code owners November 29, 2024 16:59
@ov7a ov7a linked an issue Nov 29, 2024 that may be closed by this pull request
@ov7a ov7a added this to the 8.12 RC1 milestone Nov 29, 2024
Copy link
Member

@ljacomet ljacomet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See questions below

@ov7a ov7a requested a review from ljacomet December 3, 2024 10:40
@ov7a ov7a added this pull request to the merge queue Dec 3, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 3, 2024
@ov7a ov7a added this pull request to the merge queue Dec 3, 2024
Merged via the queue into gradle:master with commit e577c25 Dec 3, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
from:contributor PR by an external contributor in:scala-plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scala Zinc Incremental compiler regression as of version 1.10.1
5 participants