-
-
Notifications
You must be signed in to change notification settings - Fork 818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v4] | [v2] Bottomsheet background/backdrop shown, but modal does not show up #1405
Comments
@gorhom : Pls help me with this issue. |
I have same issue and fix it by remove |
i had the same problem and it was fixed by adding enableDismissOnClose={true} |
@longnc100500 : But the default value of this prop itself is true. How would this fix? |
@gorhom - Is gorhom bottomsheet compatible with reanimated 3.x versions? pls respond. |
check #1125 |
@gorhom Thanks for the response. Can you pls also respond to my original query? Bottomsheet also does not open up on calling expand(). There are such intermittent issues. |
I am getting this same issue on Android with the following: It happens about 8/10 times on a Samsung A51 Device. |
software-mansion/react-native-reanimated#4419 |
@gnair03 I don't see any patch in issue you linked, can you share your patch? |
@Nodonisko : Pls use this commit as a patch: |
Used latest nightly build of 3.4.0 of reanimated which should include suggested patch and also added some delay after app start before showing bottom sheet. Not sure which one helped but it seems to work now. I am also using v5 alpha of BottomSheet. |
Great! Thanks for the feedback @Nodonisko . I was not aware of the 3.4.0 release, so that helps! We also ran nightly automations on our whole app and also did manual sanities... this issue did not recur after the patch was applied. Maybe you could reconsider the delay! |
Still having the issue: Tested with: Can only replicate this issue with our Samsung A53 test phone. On any other Android phone (and iOS) the component works perfectly. The issue seems to occur when for some reason animation starts / flickers briefly when component is mounting. And gets resolved when initiating any other bottomSheet in the screen and attempting to open the initial BottomSheet that failed. I assume this has something to do with the component and animation lifecycle and starts to work after a state reset. |
This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
This issue was closed because it has been stalled for 5 days with no activity. |
Thanks @nghiatv, it also worked for me, also I added |
Same issue here. Cant resolve |
Same issue on the samsung remotetestlab. I can reproduce only when a user disable animations on the phone. |
@aubert-creation do you know how to fix it? |
Any fix yet? this is incredibly frustrating. |
I was able to fix this issue on my end by simply using only a This might not work for everyone, but worked for me. |
@gnair03 have you ever solved this issue? |
Hi @FabianTrain - |
Thank you for the quick response! 🙏 Unfortunately the issue still comes up in my project with reanimated 3.6. I will open a new ticket. Edit: |
so any solution is here @gorhom ? i use "@gorhom/bottom-sheet": "4.6.0", and "react-native-reanimated": "3.2.0", |
thanks a lot man, |
Bug
I am using :
React-native 0.69.1
Reanimated: 3.3.0
Gorhom bottomsheet: 4.4.7
There is an intermittent issue that I have been facing on Android, ever since we upgraded our library versions to the above mentioned ones. Sometimes (on some devices) the Gorhom bottomsheets dont show up, meaning the fullscreen transparent overlay behind the actual modal is visible but the actual bottomsheet content is not. It does not come up. The app behaves like the bottomsheet would open, renders the backdrop but does not render the bottomsheet content.
Why is this happening? Any ideas? How do I fix this?
Environment info
Steps To Reproduce
##Describe what you expected to happen:
Reproducible sample code
The text was updated successfully, but these errors were encountered: