Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update hpHosts url to use https. See #1749 #1838

Closed
wants to merge 1 commit into from
Closed

Update hpHosts url to use https. See #1749 #1838

wants to merge 1 commit into from

Conversation

migueldemoura
Copy link

No description provided.

@gorhill
Copy link
Owner

gorhill commented Jul 26, 2016

Declined. This will require a non-trivial fix in order to not cause the list to be de-selected for those using it. Also any changes to that file must be accompanied by an update of checksums.txt. That's why I refuse PRs, there is typically always more to code changes, even seemingly trivial ones, than people realize.

@gorhill gorhill closed this Jul 26, 2016
@migueldemoura migueldemoura deleted the patch-1 branch July 26, 2016 15:25
@migueldemoura migueldemoura restored the patch-1 branch July 26, 2016 15:25
@migueldemoura
Copy link
Author

Didn't notice the checksums.txt, thanks for the heads up!

As for the for the whole "de-selected" issue, and given that I'm assuming the selector is using the url as the primary id, I think using an integer to identify each list is enough, as it allows unlimited modification of all fields.

One could also use the list's name as the id to avoid adding another field to the json.

Which way do you think is better, @gorhill?

@gorhill
Copy link
Owner

gorhill commented Jul 26, 2016

I'm assuming the selector is using the url as the primary id, I think using an integer to identify each list is enough, as it allows unlimited modification of all fields.

Yes, the issue is that the url is the id, I consider this technical debt from choices made back in 2013 for HTTP Switchboard. The solution I plan is in line of what you suggest, except I won't use integer, probably just a short evocative name. There will need to be a transition though, so that older versions of uBO still work with the new filter lists for a while. When I am confident most people have move onto new versions of uBO, then there will be a special version released which will patch old ids (urls) into their new shortname counterparts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants