Allow and Ignore Non-semver tags #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pulled out some code from the Order test into a testRepo struct to simplify writing tests.
Codecov Report
@@ Coverage Diff @@
## master #77 +/- ##
==========================================
+ Coverage 22.06% 22.66% +0.59%
==========================================
Files 15 15
Lines 630 631 +1
==========================================
+ Hits 139 143 +4
+ Misses 470 468 -2
+ Partials 21 20 -1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#76
This is broken up into two commits. The first just converts the error to a warning, and writes to stderr. The second adds a test, but also reworks the
order_test.gocode from my previous PR to add atestRepoto reduce some test boiler plate.Please let me know what you think, both about the behavior change and how best to address it.