subscription: add ModifySubscription functionality #714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kung-foo
reviewed
Apr 19, 2024
jackchenjc
force-pushed
the
issue-713
branch
3 times, most recently
from
47e6bf5 to
6d09349
Compare
|
Hi @kung-foo @magiconair, |
closes gopcua#713 Signed-off-by: Jack Chen <jack@iotechsys.com>
Decouple client and subscription code during subscription recreation. During this operation both the state of the client and the subscription have to be updated while holding a lock in the client. The previous implementation had both classes call each other. The control flow in the new implementation is only from the client to the subscription.
|
Rebased to |
|
Hi @kung-foo it'd be great if you could review this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #713